Add dasherized-test-name-generator-option RFC #216
Conversation
| Test name examples for `some-multi-word-service-test.js` : | ||
|
|
||
| * With `--dasherize`: `Unit | Service | some-multi-word-service` | ||
| * With `--humanize` (default today): `Unit | Service | some multi word service` |
There was a problem hiding this comment.
IMHO this RFC should just set the new default to dasherize, but without adding any new options that would increase the complexity
There was a problem hiding this comment.
Agreed, this RFC should only be about changing the defaults. I am generally 👎 on adding new options...
|
I also agree that humanized names make no sense. I'm all in to change it. |
|
Heh, I actually think we should remove the description completely... But if we can't do that, we should use dasherized version. |
|
According to your feedback, I updated the RFC by removing the options. The fix is also simpler, although I don't know the uses of |
@rwjblue if we pull in emberjs/ember-qunit#258 then removing the test description is not an option can we do anything to move this forward? I'm constantly being trolled by this when trying to test only single components... |
I think you misunderstand me, I am saying we do not need both a name and a description. We should only have one, and actually it matches better with emberjs/ember-qunit#258!! |
|
@rwjblue indeed, I still don't understand what you mean. what are your definitions of "name" and "description"? |
|
@GabrielCW - Thank you very much for taking the time to write up this RFC! I think it's very clearly correct, and in our opinion points out some pretty bad developer ergonomics in the current default generation system. It has been the policy for quite some time in Ember-land to consider bad developer ergonomics to be bugs. I am going to close this RFC as unneeded and advocate for landing the changes proposed in this RFC as a straight up bug fix. Thank you again for helping push this forward! |
See emberjs/ember.js#14915